Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 upload disabled依然可删除问题 #1036

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

honkinglin
Copy link
Collaborator

@honkinglin honkinglin commented Jul 4, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Upload): 修复 disabled 依然可删除问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@honkinglin
Copy link
Collaborator Author

re #1034

@codecov-commenter
Copy link

Codecov Report

Merging #1036 (9e8138c) into develop (7b04365) will decrease coverage by 0.00%.
The diff coverage is 50.22%.

@@             Coverage Diff             @@
##           develop    #1036      +/-   ##
===========================================
- Coverage    60.40%   60.40%   -0.01%     
===========================================
  Files          937      951      +14     
  Lines        16498    16641     +143     
  Branches      3743     3801      +58     
===========================================
+ Hits          9966    10052      +86     
- Misses        6532     6589      +57     
Impacted Files Coverage Δ
src/_util/dom.ts 42.59% <ø> (ø)
src/_util/helper.ts 41.07% <ø> (ø)
src/_util/insertCSS.ts 0.00% <ø> (ø)
src/_util/number.ts 33.33% <ø> (ø)
src/_util/setStyle.ts 0.00% <ø> (ø)
src/_util/useDialogEsc.ts 46.66% <ø> (ø)
src/_util/useDragSorter.tsx 25.45% <ø> (ø)
src/_util/useRipple.ts 26.76% <ø> (ø)
src/anchor/Anchor.tsx 81.33% <ø> (ø)
src/anchor/_util/dom.ts 66.66% <ø> (ø)
... and 119 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c3ea20...9e8138c. Read the comment docs.

@honkinglin honkinglin merged commit 4997805 into develop Jul 4, 2022
@honkinglin honkinglin deleted the fix/upload/disabled branch July 4, 2022 04:51
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

完成

@github-actions github-actions bot mentioned this pull request Jul 4, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants