Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: color-picker ui 优化 #1048

Merged
merged 9 commits into from
Aug 4, 2022
Merged

feat: color-picker ui 优化 #1048

merged 9 commits into from
Aug 4, 2022

Conversation

insekkei
Copy link
Collaborator

@insekkei insekkei commented Jul 6, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(color-picker): 优化 ui,去掉 closeBtn

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

完成

@honkinglin
Copy link
Collaborator

这 common 节点有点落后了,如果不需要更新common可以不提交上来

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #1048 (6be5fb0) into develop (c4c5d1d) will increase coverage by 0.11%.
The diff coverage is 69.43%.

@@             Coverage Diff             @@
##           develop    #1048      +/-   ##
===========================================
+ Coverage    60.18%   60.29%   +0.11%     
===========================================
  Files          959      969      +10     
  Lines        16979    17151     +172     
  Branches      3906     3945      +39     
===========================================
+ Hits         10218    10342     +124     
- Misses        6761     6809      +48     
Impacted Files Coverage Δ
src/_util/useAnimation.ts 100.00% <ø> (ø)
src/_util/useClickOutside.ts 86.36% <ø> (ø)
src/_util/useCommonClassName.ts 100.00% <ø> (ø)
src/_util/useRipple.ts 26.76% <ø> (ø)
src/affix/Affix.tsx 85.93% <ø> (ø)
src/anchor/AnchorItem.tsx 85.71% <ø> (ø)
src/avatar/AvararGroup.tsx 92.00% <ø> (ø)
src/avatar/Avatar.tsx 95.74% <ø> (ø)
src/badge/Badge.tsx 100.00% <ø> (ø)
src/breadcrumb/Breadcrumb.tsx 100.00% <ø> (ø)
... and 192 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@insekkei insekkei changed the title WIP: Fix/tabs feat: color-picker ui 优化 Aug 4, 2022
@honkinglin honkinglin merged commit 86a4d84 into Tencent:develop Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants