Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 修复可选中行table组件,data为空数据时,默认全选按钮会选中的问题 #1061

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

hi-zhaoyeqing
Copy link
Contributor

@hi-zhaoyeqing hi-zhaoyeqing commented Jul 10, 2022

修复可选中行table组件,data为空数据时,默认全选按钮会选中的问题

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

目前
image
修复后
image
原因
对空数据没进行判断
解决方案
对空数据做处理

📝 更新日志

  • fix(table): 修复可选中行table组件,data为空数据时,默认全选按钮会选中的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@codecov-commenter
Copy link

Codecov Report

Merging #1061 (c68354e) into develop (7b04365) will decrease coverage by 0.06%.
The diff coverage is 62.22%.

@@             Coverage Diff             @@
##           develop    #1061      +/-   ##
===========================================
- Coverage    60.40%   60.33%   -0.07%     
===========================================
  Files          937      955      +18     
  Lines        16498    16764     +266     
  Branches      3743     3829      +86     
===========================================
+ Hits          9966    10115     +149     
- Misses        6532     6649     +117     
Impacted Files Coverage Δ
src/_util/dom.ts 42.59% <ø> (ø)
src/_util/helper.ts 41.07% <ø> (ø)
src/_util/insertCSS.ts 0.00% <ø> (ø)
src/_util/number.ts 33.33% <ø> (ø)
src/_util/setStyle.ts 0.00% <ø> (ø)
src/_util/useDialogEsc.ts 46.66% <ø> (ø)
src/_util/useDragSorter.tsx 25.45% <ø> (ø)
src/_util/useRipple.ts 26.76% <ø> (ø)
src/anchor/Anchor.tsx 81.33% <ø> (ø)
src/anchor/_util/dom.ts 66.66% <ø> (ø)
... and 141 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3e9e34...c68354e. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2022

完成

@hi-zhaoyeqing hi-zhaoyeqing force-pushed the fix/table-select-all branch 4 times, most recently from aca4dfe to c1c6c4c Compare July 12, 2022 11:55
修复可选中行table组件,data为空数据时,默认全选按钮会选中的问题
@hi-zhaoyeqing hi-zhaoyeqing force-pushed the fix/table-select-all branch from c1c6c4c to 610f6c5 Compare July 12, 2022 12:35
@chaishi chaishi merged commit 6c75d5a into Tencent:develop Jul 13, 2022
@github-actions github-actions bot mentioned this pull request Jul 18, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants