-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(button): 支持 href、tag、suffix api #1120
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1120 +/- ##
===========================================
+ Coverage 60.29% 60.33% +0.03%
===========================================
Files 955 957 +2
Lines 16781 16925 +144
Branches 3845 3873 +28
===========================================
+ Hits 10118 10211 +93
- Misses 6663 6714 +51
Continue to review full report at Codecov.
|
e16446d
to
4480df9
Compare
@@ -282,6 +318,9 @@ exports[`tips.jsx 1`] = ` | |||
fill-opacity="0.9" | |||
/> | |||
</svg> | |||
<span | |||
class="t-button__text" | |||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里出现了空元素,需要看下原因
/** | ||
* 点击确认按钮时触发 | ||
*/ | ||
onConfirm?: (options: { e: MouseEvent<HTMLDivElement | HTMLButtonElement> }) => void; | ||
onConfirm?: (options: { e: MouseEvent<HTMLElement> }) => void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些变更是否符合预期
🤔 这个 PR 的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
ffeat(button): 支持 href、tag、suffix
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单