Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): empty string trigger on-search #1176

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

uyarn
Copy link
Collaborator

@uyarn uyarn commented Jul 27, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Select): 修复回删空字符串不触发onSearch的缺陷

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2022

完成

@uyarn uyarn force-pushed the fix/select/empty-search branch 2 times, most recently from 9e0cc3a to 469b255 Compare July 27, 2022 09:30
@uyarn uyarn force-pushed the fix/select/empty-search branch from 469b255 to 5f88c3c Compare July 27, 2022 09:42
@codecov-commenter
Copy link

Codecov Report

Merging #1176 (8a30374) into develop (f5430d5) will decrease coverage by 0.13%.
The diff coverage is 52.34%.

@@             Coverage Diff             @@
##           develop    #1176      +/-   ##
===========================================
- Coverage    60.29%   60.15%   -0.14%     
===========================================
  Files          955      959       +4     
  Lines        16781    16980     +199     
  Branches      3845     3903      +58     
===========================================
+ Hits         10118    10215      +97     
- Misses        6663     6765     +102     
Impacted Files Coverage Δ
src/card/_example/base.jsx 100.00% <ø> (ø)
src/card/_example/bordered-none.jsx 75.00% <ø> (ø)
src/card/_example/footer-content-actions.jsx 80.00% <ø> (ø)
src/card/_example/footer.jsx 100.00% <ø> (ø)
src/card/_example/header-all-props.jsx 100.00% <ø> (ø)
src/card/_example/header-bordered.jsx 75.00% <ø> (ø)
src/card/_example/header-description.jsx 100.00% <ø> (ø)
src/card/_example/header-footer-actions.jsx 80.00% <ø> (ø)
...c/card/_example/header-subtitle-footer-actions.jsx 80.00% <ø> (ø)
src/card/_example/header-subtitle.jsx 100.00% <ø> (ø)
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890342b...8a30374. Read the comment docs.

@honkinglin honkinglin merged commit 51534d5 into develop Jul 28, 2022
@honkinglin honkinglin deleted the fix/select/empty-search branch July 28, 2022 01:42
@github-actions github-actions bot mentioned this pull request Aug 1, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants