Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): 继承dropdown样式 #1187

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

CodingOnStar
Copy link
Contributor

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#1184

💡 需求背景和解决方案

1、dropdown声明overlayClassName时,未继承t-dropdown属性
截屏2022-07-29 12 11 15

📝 更新日志

声明overlayClassName时,继承t-dropdown属性

  • fix(组件名称): 处理问题或特性描述 ...

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2022

完成

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #1187 (1b3c198) into develop (c4c5d1d) will increase coverage by 0.03%.
The diff coverage is 73.07%.

@@             Coverage Diff             @@
##           develop    #1187      +/-   ##
===========================================
+ Coverage    60.18%   60.21%   +0.03%     
===========================================
  Files          959      967       +8     
  Lines        16979    17068      +89     
  Branches      3906     3926      +20     
===========================================
+ Hits         10218    10277      +59     
- Misses        6761     6791      +30     
Impacted Files Coverage Δ
src/dropdown/Dropdown.tsx 81.48% <ø> (ø)
src/dropdown/_example/base.jsx 83.33% <ø> (ø)
src/dropdown/_example/child.jsx 80.00% <ø> (ø)
src/dropdown/_example/disabled.jsx 83.33% <ø> (ø)
src/dropdown/_example/split.jsx 83.33% <ø> (ø)
src/select/defaultProps.ts 100.00% <ø> (ø)
src/tree/useStore.ts 56.25% <0.00%> (-5.82%) ⬇️
src/cascader/core/helper.ts 92.85% <66.66%> (+3.20%) ⬆️
src/grid/Col.tsx 97.29% <100.00%> (ø)
src/grid/Row.tsx 75.86% <100.00%> (-1.19%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca9fd10...1b3c198. Read the comment docs.

@honkinglin honkinglin merged commit 5461e9f into Tencent:develop Jul 29, 2022
@github-actions github-actions bot mentioned this pull request Aug 1, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants