Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/message config support #1239

Merged
merged 6 commits into from
Aug 10, 2022

Conversation

kenzyyang
Copy link
Contributor

@kenzyyang kenzyyang commented Aug 6, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

React api 中有 message.config 全局配置的方法描述,但是代码并未实现,本PR 用于实现此功能。

📝 更新日志

  • fix(组件名称): 处理问题或特性描述 ...

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2022

完成

@kenzyyang kenzyyang force-pushed the fix/message_config_support branch from a9e848f to dbad7b2 Compare August 6, 2022 08:02
@codecov-commenter
Copy link

Codecov Report

Merging #1239 (250bbe1) into develop (ca9bc02) will decrease coverage by 0.44%.
The diff coverage is 41.32%.

@@             Coverage Diff             @@
##           develop    #1239      +/-   ##
===========================================
- Coverage    60.29%   59.85%   -0.45%     
===========================================
  Files          969      994      +25     
  Lines        17151    17525     +374     
  Branches      3945     4004      +59     
===========================================
+ Hits         10342    10489     +147     
- Misses        6809     7036     +227     
Impacted Files Coverage Δ
src/affix/_example/container.jsx 85.71% <ø> (-0.96%) ⬇️
src/badge/_example/custom.jsx 100.00% <ø> (ø)
src/button/_example/base.tsx 100.00% <ø> (ø)
src/form/hooks/useInstance.tsx 48.80% <0.00%> (ø)
src/message/MessageClose.tsx 77.77% <ø> (ø)
src/select/_example/custom-options.jsx 88.88% <ø> (ø)
src/image-viewer/hooks/usePosition.ts 2.63% <2.63%> (ø)
src/image-viewer/utils.ts 5.26% <5.26%> (ø)
src/image-viewer/hooks/useScale.ts 6.25% <6.25%> (ø)
src/image-viewer/ImageViewerModel.tsx 6.42% <6.42%> (ø)
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kenzyyang kenzyyang changed the title 【WIP】Fix/message config support Fix/message config support Aug 8, 2022
@honkinglin honkinglin merged commit 581487a into Tencent:develop Aug 10, 2022
@github-actions github-actions bot mentioned this pull request Aug 15, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants