Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 重构 popup 组件 & 修复 ref 强依赖问题 #1256

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

honkinglin
Copy link
Collaborator

@honkinglin honkinglin commented Aug 9, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(Popup): 重构 popup 组件 & 修复 ref 强依赖问题

  • feat(Popup): ref 支持获取内部 popper 实例以及更多内部元素

  • feat(Popup): 不再生成 div 节点包裹 trigger 元素,className、style 属性废弃,可自行包裹 div 节点调整 className、style 属性

  • feat(Popup): overlayStyle 调整为控制 t-popup 层级,新增 overlayInnerStyle 控制 t-popup__content 层级与原先 overlayStyle 效果一致。

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

完成

@honkinglin
Copy link
Collaborator Author

re: #1100

@honkinglin honkinglin force-pushed the feat/popup/refactor branch 2 times, most recently from 32469ee to a9e9941 Compare August 10, 2022 02:51
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #1256 (5bed7f3) into develop (153e56e) will decrease coverage by 0.06%.
The diff coverage is 69.14%.

❗ Current head 5bed7f3 differs from pull request most recent head de988d8. Consider uploading reports for the commit de988d8 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1256      +/-   ##
===========================================
- Coverage    59.87%   59.80%   -0.07%     
===========================================
  Files          992     1007      +15     
  Lines        17502    17718     +216     
  Branches      4005     4053      +48     
===========================================
+ Hits         10479    10596     +117     
- Misses        7023     7122      +99     
Impacted Files Coverage Δ
src/calendar/Calendar.tsx 81.60% <ø> (ø)
src/date-picker/DatePicker.tsx 14.66% <ø> (ø)
src/date-picker/DateRangePicker.tsx 10.00% <ø> (ø)
src/date-picker/defaultProps.ts 100.00% <ø> (ø)
src/message/MessageClose.tsx 77.77% <ø> (ø)
src/message/_example/close-all.jsx 25.00% <ø> (ø)
src/message/_example/close-function.jsx 41.66% <ø> (ø)
src/select/base/PopupContent.tsx 92.30% <ø> (ø)
src/table/SorterButton.tsx 91.66% <ø> (ø)
src/table/TBody.tsx 100.00% <ø> (ø)
... and 66 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@honkinglin honkinglin force-pushed the feat/popup/refactor branch 3 times, most recently from afea53f to 9641674 Compare August 10, 2022 12:46
@honkinglin honkinglin force-pushed the feat/popup/refactor branch from 9641674 to 5bed7f3 Compare August 10, 2022 12:49
@honkinglin honkinglin force-pushed the feat/popup/refactor branch from 5bed7f3 to de988d8 Compare August 10, 2022 12:49
@uyarn uyarn merged commit b420a15 into develop Aug 11, 2022
@uyarn uyarn deleted the feat/popup/refactor branch August 11, 2022 08:58
@github-actions github-actions bot mentioned this pull request Aug 15, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants