-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(tabs): create tabs panel not update tab bar when async generate it (#1254) #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1258 +/- ##
===========================================
+ Coverage 59.73% 59.83% +0.09%
===========================================
Files 1007 1007
Lines 17661 17662 +1
Branches 4032 4033 +1
===========================================
+ Hits 10550 10568 +18
+ Misses 7111 7094 -17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
LeeJim
requested changes
Aug 12, 2022
LeeJim
reviewed
Aug 12, 2022
更新下snapshot |
我的问题应该不是因为 snapshot,我没有改动 example |
honkinglin
approved these changes
Aug 15, 2022
LeeJim
approved these changes
Aug 15, 2022
Merged
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是?
🔗 相关 Issue
#1254
💡 需求背景和解决方案
具体问题
使用异步 api 去创建 tab panel 的时候会导致 tab nav 的 active index 没办法计算出来
解决方法
📝 更新日志
fix(tabs): create tabs panel not update tab bar when async generate it
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单