Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Form): requireMark defaultValue #1602

Merged
merged 1 commit into from
Oct 19, 2022
Merged

fix(Form): requireMark defaultValue #1602

merged 1 commit into from
Oct 19, 2022

Conversation

honkinglin
Copy link
Collaborator

@honkinglin honkinglin commented Oct 18, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Form): 调整 requireMark showErrorMessage等默认值

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@honkinglin honkinglin linked an issue Oct 18, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

完成

@codecov-commenter
Copy link

Codecov Report

Merging #1602 (8625bfe) into develop (8a9ef3a) will increase coverage by 3.70%.
The diff coverage is 68.24%.

@@             Coverage Diff             @@
##           develop    #1602      +/-   ##
===========================================
+ Coverage    61.00%   64.71%   +3.70%     
===========================================
  Files         1030     1045      +15     
  Lines        17933    18433     +500     
  Branches      4121     4199      +78     
===========================================
+ Hits         10940    11928     +988     
+ Misses        6993     6505     -488     
Impacted Files Coverage Δ
src/_util/usePluginConfig.ts 0.00% <0.00%> (ø)
src/_util/useRipple.ts 26.38% <0.00%> (-0.38%) ⬇️
src/_util/wrapDisabledButton.tsx 0.00% <0.00%> (ø)
src/alert/_example/base.jsx 100.00% <ø> (ø)
src/alert/_example/operation.jsx 60.00% <0.00%> (-40.00%) ⬇️
src/card/Card.tsx 97.36% <ø> (ø)
src/cascader/_example/check-strictly.jsx 77.77% <ø> (ø)
src/cascader/_example/collapsed.jsx 87.50% <ø> (ø)
src/cascader/_example/disabled.jsx 100.00% <ø> (ø)
src/cascader/_example/filterable.jsx 77.77% <ø> (ø)
... and 260 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@uyarn uyarn changed the title fix: form requireMark defaultValue fix(Form): requireMark defaultValue Oct 19, 2022
@uyarn uyarn merged commit 76fcf05 into develop Oct 19, 2022
@uyarn uyarn deleted the fix/form/requiredmark branch October 19, 2022 11:44
@github-actions github-actions bot mentioned this pull request Oct 26, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Form] 仅使用Form的样式时,requiredMark显示问题
3 participants