Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree-select): 修复 valueDisplay 和 filterable 同时设置时的显示问题 #1674

Conversation

moecasts
Copy link
Collaborator

@moecasts moecasts commented Nov 7, 2022

fix #1668

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#1668

💡 需求背景和解决方案

背景

valueDisplayfilterable 同时开启时(单选模式下),输入框的值没有清空,且输入的值无法感知。

解决方案

开启 filterablevalueDisplay 时,如果处于选择(输入状态)则不传 valueDisplay

  const internalInputValueDisplay = useMemo(() => {
    // 只有单选且下拉展开时需要隐藏 valueDisplay
    if (filterable && popupVisible) {
      return undefined;
    }
    return normalizedValueDisplay;
  }, [filterable, popupVisible, normalizedValueDisplay]);

placeholder 优先展示 valueDisplay 内容。

📝 更新日志

  • fix(tree-select): 修复 valueDisplay 和 filterable 同时设置时的显示问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

完成

@moecasts moecasts force-pushed the bugfix/tree-select-value-display-and-filter-conflict branch from c9d27dc to d93a1e0 Compare November 7, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TreeSelect] valueDisplay 和 filterable 同时设置时,输入框输入无法正确显示
2 participants