Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reafcator: cascader use select-input #990

Merged
merged 5 commits into from
Jul 4, 2022

Conversation

PengYYYYY
Copy link
Contributor

@PengYYYYY PengYYYYY commented Jun 27, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

关联PR Tencent/tdesign-common#613

📝 更新日志

  • refactor(Cascader): 基于 select-input 重构, 文本过长省略使用原生 title 展示全文本,不再使用 tooltip 组件。
  • feat(Cascader): 增加 popupVisible, readonly, selectInputProps, onPopupVisibleChange 属性,具体描述查看文档
  • fix(Cascader): 修复数据中 value 的数据类型为 number 时,clearable 失效

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@PengYYYYY PengYYYYY changed the title Refactor/cascader reafcator: cascader use select-input Jun 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2022

完成

@PengYYYYY PengYYYYY changed the title reafcator: cascader use select-input [WIP]reafcator: cascader use select-input Jun 27, 2022
@PengYYYYY PengYYYYY force-pushed the refactor/cascader branch from a3b8567 to 8a7949f Compare July 2, 2022 08:13
@PengYYYYY PengYYYYY force-pushed the refactor/cascader branch from ab118ff to 8027339 Compare July 3, 2022 12:55
@codecov-commenter
Copy link

Codecov Report

Merging #990 (8027339) into develop (7b04365) will decrease coverage by 0.05%.
The diff coverage is 47.73%.

@@             Coverage Diff             @@
##           develop     #990      +/-   ##
===========================================
- Coverage    60.40%   60.35%   -0.06%     
===========================================
  Files          937      951      +14     
  Lines        16498    16623     +125     
  Branches      3743     3791      +48     
===========================================
+ Hits          9966    10032      +66     
- Misses        6532     6591      +59     
Impacted Files Coverage Δ
src/_util/dom.ts 42.59% <ø> (ø)
src/_util/helper.ts 41.07% <ø> (ø)
src/_util/insertCSS.ts 0.00% <ø> (ø)
src/_util/number.ts 33.33% <ø> (ø)
src/_util/setStyle.ts 0.00% <ø> (ø)
src/_util/useDialogEsc.ts 46.66% <ø> (ø)
src/_util/useDragSorter.tsx 25.45% <ø> (ø)
src/_util/useRipple.ts 26.76% <ø> (ø)
src/anchor/Anchor.tsx 81.33% <ø> (ø)
src/anchor/_util/dom.ts 66.66% <ø> (ø)
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df1e652...8027339. Read the comment docs.

@PengYYYYY PengYYYYY changed the title [WIP]reafcator: cascader use select-input reafcator: cascader use select-input Jul 3, 2022
@honkinglin honkinglin merged commit aefd00d into Tencent:develop Jul 4, 2022
This was referenced Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants