Specification for host list view #77

gnehapk · 2016-12-15T17:56:19Z

Addresses #75.
@r0h4n @anivargi @brainfunked @nthomas-redhat @kamleshverma1 Please review.

nthomas-redhat · 2016-12-16T07:52:18Z

specs/host_list_view.adoc

+
+The details shown for each host in UI is -
+
+* fqdn


Only fqdn in list view?
In the spec, you need to talk about all attributes specified in UX designs and also the current gaps(in terms of API support) to achieve them

nthomas-redhat · 2016-12-16T07:55:05Z

specs/host_list_view.adoc

+
+== Use Cases
+
+Users can see the list of host present in Tendrl. They can also filter and sort the list. 


What are the filtering and sorting options avaiulable

nthomas-redhat · 2016-12-16T07:57:10Z

specs/host_list_view.adoc

+
+=== Impacted Modules:
+
+==== Tendrl API impact:


Need to add the specifics here, the list of APIs required and req/resp details

nthomas-redhat · 2016-12-16T08:05:40Z

specs/host_list_view.adoc

+==== Tendrl API impact:
+
+
+==== Notifications/Monitoring impact:


How the live status updates are handled, say host status change or utlization changes?
How the asynchronous notifications from backend are handled updated on the list view?

nthomas-redhat · 2016-12-16T08:07:10Z

specs/host_list_view.adoc

+
+== Dependencies:
+
+https://github.com/Tendrl/tendrl_frontend/issues/65


Any other dependencies? APIs? Montoring/eventing? Capture those as github issues and link it here

shtripat · 2016-12-16T13:50:47Z

specs/host_list_view.adoc

+* Role
+* Alerts
+
+API supports present now is for -


shtripat · 2016-12-16T13:51:04Z

specs/host_list_view.adoc

+
+== Use Cases
+
+Users can see the list of host present in Tendrl. They can also 


%s/host/hosts/g

shtripat · 2016-12-16T13:51:57Z

specs/host_list_view.adoc

+* Create a view for listing host details.
+* For showing used storage, cpu utilisation and memory used, use donut and trending chart component.
+* This view will use generate-list component for listing host. The list data will be passed to this component from the controller.
+* Implement filer and sorting functionality.


%s/filer/filtering/g

shtripat · 2016-12-16T13:52:23Z

specs/host_list_view.adoc

+* For showing used storage, cpu utilisation and memory used, use donut and trending chart component.
+* This view will use generate-list component for listing host. The list data will be passed to this component from the controller.
+* Implement filer and sorting functionality.
+* Filter parameter(name/cluster/role/status) should be sent to API to fetch the filtered list of host.


%s/list of host/list of hosts/g

shtripat · 2016-12-16T13:52:38Z

specs/host_list_view.adoc

+* This view will use generate-list component for listing host. The list data will be passed to this component from the controller.
+* Implement filer and sorting functionality.
+* Filter parameter(name/cluster/role/status) should be sent to API to fetch the filtered list of host.
+* Sorting parameter(name and asc/desc) should be sent to API to fetch sorted list of host.


%s/host/hosts/g

shtripat · 2016-12-16T13:54:24Z

specs/host_list_view.adoc

+
+=== Alternatives
+
+Host list can have its own html template instead of using generate-list component. But the code will be redundant as the same functionality and layout is going to be used in all list views.


How do we achieve clickability of certain column items say hosts and pools under cluster lists should link to hosts and pool lists respectively. Is this flexibility achievable using this mechanism?

gnehapk · 2016-12-17T07:40:43Z

specs/host_list_view.adoc

+Required Input from Anup - 
+
+* To add the response format for the API call
+* To add the polling API call and its response format	


@anivargi Please provide the necessary inputs here.

gnehapk · 2016-12-17T07:41:10Z

specs/host_list_view.adoc

+
+==== Notifications/Monitoring impact:
+
+Required Input from Anmol: To add the response format for monitoring data


@anmolbabu Please provide the necessary input here.

@gnehapk The details that need to go here are captured as part of #81 please reference this from here.

gnehapk · 2016-12-19T09:18:59Z

Adding @cloudbehl

ltrilety · 2016-12-20T09:59:39Z

specs/host_list_view.adoc

+* Status
+* IP Address
+* Storage Usage
+* Utilisation


Utilization of what - CPU utilization?

ltrilety · 2016-12-20T10:01:06Z

specs/host_list_view.adoc

+* Host Name
+* IP Address
+* Storage Usage
+* Utilisation


The same as in previous comment, what utilization is meant here. Probably CPU but it's not clear.

gnehapk · 2016-12-20T10:06:06Z

@cloudbehl @anivargi I have updated the PR. Please review it.

kamleshverma1 · 2016-12-21T11:26:13Z

@anivargi For the host list view, below are the data that is not present in the json response of host-list -

Host IP
Role

Host-list - UX design - https://redhat.invisionapp.com/share/BR8JDCGSQ#/screens/212034116

kamleshverma1 · 2016-12-21T12:21:31Z

@anivargi @gnehapk @brainfunked
Ideally 'key' of Object should be some "static name" in order to access the value of it . it should not be dynamic (in this case - node_id) as such in response format -

Example:
{

"nodes":[
    {
        "3038c577-b233-4513-926d-a8a1ac63b0a3":  {

               "fqdn":"dhcp43-189.lab.eng.blr.redhat.com",
               "machine_id":"a2e4163a1a8e4b28afb1a17e6a1d9962",
               "node_id":"3038c577-b233-4513-926d-a8a1ac63b0a3"

        },
        "stats":{}
    }
]

}

Here , i am fine with "stats" key which is static name. and also we can access the value of it using dot operator . but for "3038c577-b233-4513-926d-a8a1ac63b0a3" , it can have any node-id which is dynamic (we don't know what it can have because it is not static name). and accessing this value in UI will be tricky and difficult . Can we have some static name instead of dynamic id?

brainfunked · 2016-12-21T13:06:26Z

@kamleshverma1 I can't think of a specific scenario where that's a problem. It is understood that the keys insides nodes always refer to a host id. Do you have an example where this is a problem?

shtripat · 2016-12-22T08:34:25Z

I feel @kamleshverma1 wants the details as below (even I feel it should be like that) -

{
  'nodes': [
    {
      'node_id': "3038c577-b233-4513-926d-a8a1ac63b0a3",
      "fqdn":"dhcp43-189.lab.eng.blr.redhat.com",
      "machine_id":"a2e4163a1a8e4b28afb1a17e6a1d9962",
      "stats": {}
    },
    .............
  ]
}

dahorak · 2017-01-02T09:09:39Z

specs/host_list_view.adoc

+
+The details shown for each host in UI is -
+
+* Host Name


Does the Host Name means just host name (the first part without the domain) or FQDN? Especially in the case of FQDN, it might be quite long and it might break the rest of the layout.

dahorak · 2017-01-02T09:10:08Z

specs/host_list_view.adoc

+* CPU Utilisation
+* Memory Usage
+* Cluster Name
+* Role


Would it be possible, that node will have more than one role and do we count with this situation?

nthomas-redhat requested changes Dec 16, 2016

View reviewed changes

gnehapk force-pushed the host-list-specification branch from 23bc3ea to 3f0a76c Compare December 16, 2016 11:02

shtripat reviewed Dec 16, 2016

View reviewed changes

gnehapk force-pushed the host-list-specification branch 2 times, most recently from a14dcc6 to 534e712 Compare December 17, 2016 07:39

gnehapk commented Dec 17, 2016

View reviewed changes

gnehapk force-pushed the host-list-specification branch 2 times, most recently from ef98f2d to 6dc1762 Compare December 20, 2016 09:42

ltrilety reviewed Dec 20, 2016

View reviewed changes

specs/host_list_view.adoc

* Status

* IP Address

* Storage Usage

* Utilisation

Copy link

ltrilety Dec 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utilization of what - CPU utilization?

ltrilety reviewed Dec 20, 2016

View reviewed changes

Specification for host list view

76dd84e

gnehapk force-pushed the host-list-specification branch from 6dc1762 to 76dd84e Compare December 21, 2016 07:22

dahorak reviewed Jan 2, 2017

View reviewed changes

mkudlej mentioned this pull request Jan 2, 2017

host list test including monitoring data usmqe/usmqe-tests#21

Closed

ltrilety mentioned this pull request Feb 3, 2017

import cluster framework plus test usmqe/usmqe-tests#31

Merged

r0h4n merged commit 3d19cae into Tendrl:master Apr 28, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Specification for host list view #77

Specification for host list view #77

gnehapk commented Dec 15, 2016

nthomas-redhat Dec 16, 2016

nthomas-redhat Dec 16, 2016

nthomas-redhat Dec 16, 2016

nthomas-redhat Dec 16, 2016

nthomas-redhat Dec 16, 2016

shtripat Dec 16, 2016

shtripat Dec 16, 2016

shtripat Dec 16, 2016

shtripat Dec 16, 2016

shtripat Dec 16, 2016

shtripat Dec 16, 2016

gnehapk Dec 17, 2016

gnehapk Dec 17, 2016

anmolbabu Dec 18, 2016

gnehapk commented Dec 19, 2016 •

edited

Loading

ltrilety Dec 20, 2016

ltrilety Dec 20, 2016

gnehapk commented Dec 20, 2016

kamleshverma1 commented Dec 21, 2016 •

edited

Loading

kamleshverma1 commented Dec 21, 2016 •

edited

Loading

brainfunked commented Dec 21, 2016

shtripat commented Dec 22, 2016 •

edited

Loading

dahorak Jan 2, 2017

dahorak Jan 2, 2017


		== Use Cases

		Users can see the list of host present in Tendrl. They can also filter and sort the list.

		==== Tendrl API impact:


		==== Notifications/Monitoring impact:


		== Dependencies:

		https://github.com/Tendrl/tendrl_frontend/issues/65


		=== Alternatives

		Host list can have its own html template instead of using generate-list component. But the code will be redundant as the same functionality and layout is going to be used in all list views.


		==== Notifications/Monitoring impact:

		Required Input from Anmol: To add the response format for monitoring data

Specification for host list view #77

Specification for host list view #77

Conversation

gnehapk commented Dec 15, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gnehapk commented Dec 19, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gnehapk commented Dec 20, 2016

kamleshverma1 commented Dec 21, 2016 • edited Loading

kamleshverma1 commented Dec 21, 2016 • edited Loading

brainfunked commented Dec 21, 2016

shtripat commented Dec 22, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gnehapk commented Dec 19, 2016 •

edited

Loading

kamleshverma1 commented Dec 21, 2016 •

edited

Loading

kamleshverma1 commented Dec 21, 2016 •

edited

Loading

shtripat commented Dec 22, 2016 •

edited

Loading