refactor: address IntelliJ QAPlug plugin findings #51
Conversation
jdrueckert
added
Size: S
* make final fields static * remove unnecessary local before return * remove instanceof checks in catch clause * avoid throwing java.lang.Exception * remove null checks covered by instanceof check * remove toString on String objects * remove overrides that only call their super * remove unused private methods * remove unnecessary if statement nesting * remove unused local variables * use try-with-resources to close resources after use * use equals() to compare object references * fix broken javadoc references * fix disallowed self-closing and empty javadoc elements * fix bad use of symbols in javadoc * fix disallowed list item tag in javadoc without surrounding list * fix erroneous javadoc tags * fix emphasize tags in javadoc * remove illegal throws * remove unused imports Related: Terasology/CoreRendering#75 Terasology/Furnishings#17 Terasology/Health#105 Terasology/Inventory#51 Terasology/Behaviors#114 Terasology/CoreWorlds#45 Terasology/FlexiblePathfinding#32 Adds to #3859
|
@soloturn thanks for the approval! I need to sort out our GitHub teams so that you can actually approve 🙈 |
|
@jdrueckert i would really appreciate if you merge this one or get it merged. |
* line too long
* logger not parameterized
* intellij warnings about formatting, e.g. @ReceiveEvent(components = {InventoryComponent.class}) replaced with @ReceiveEvent(components = InventoryComponent.class)
* unused private field
|
seems approve worked thank you @jdrueckert . but merge button is not active. is it for you? |
It is not active for me either which is due to the fact that the pipeline hasn't passed. Now that we have our module pipelines set up again (after our recent CI changes), we can run the pipeline again and if it passes - which I'm expecting it to do - we can go ahead and merge. |
Relates to MovingBlocks/Terasology#5149