Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TerraBlender placeholder biome generation #9

Closed
gniftygnome opened this issue Dec 15, 2023 · 0 comments
Closed

TerraBlender placeholder biome generation #9

gniftygnome opened this issue Dec 15, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@gniftygnome
Copy link
Contributor

There is evidence of TB placeholder biome generation in the wild now (i.e. mods are actually using TB methods which cause the placeholder to be returned as the found biome by TB's primary search, then replaced by the secondary search). Despite the performance implications, we must implement TB's double call to MultiNoiseUtil.SearchTree.TreeNode.getResultingNode().

As it does in TB itself, this will result in slower worldgen when generating chunks where the second search is used. However, it should be in line with TB's own behavior and will not further slow any Biolith code paths.

See also:

@gniftygnome gniftygnome added the bug Something isn't working label Dec 15, 2023
gniftygnome added a commit that referenced this issue Dec 18, 2023
…stem.

- Refactor TerraBlender compatibility to use newer API features
- Implement TerraBlender's placeholder system; resolves #9

(cherry picked from commit e422e47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant