Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move DataCustodianTraits into CatalogMemberTraits #5172

Merged
merged 4 commits into from
Jan 28, 2021
Merged

Move DataCustodianTraits into CatalogMemberTraits #5172

merged 4 commits into from
Jan 28, 2021

Conversation

nf-s
Copy link
Contributor

@nf-s nf-s commented Jan 25, 2021

Move DataCustodianTraits into CatalogMemberTraits

  • DataCustodianTraits had a single string trait: dataCustodian
  • Some catalog items were missing DataCustodianTraits - even though it is used in Description.jsx
  • So I merged it into CatalogMemberTraits and CatalogMemberReferenceTraits

Related issues:

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated CHANGES.md with what I changed.

@nf-s nf-s mentioned this pull request Jan 25, 2021
Closed
@nf-s nf-s merged commit 3822692 into next Jan 28, 2021
@nf-s nf-s deleted the move-data-custodian-traits branch January 28, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeyboardSounds KeyboardSounds KeyboardSounds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nf-s @KeyboardSounds