Apply new Result/TerriaError pattern to traits.fromJson() #5440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply new
Result
/TerriaError
pattern totraits.fromJson()
This depends on #5429
This makes some changes to how we handle errors update/upserting JSON into the model. If an error is occurred while updating a trait in a model (for example, a trait doesn't exist) it will not interrupt updating the model — it will just add an error message and continue.
Checklist