Various fixes for SOS. #6059
Merged
Various fixes for SOS. #6059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Re-enables procedure and observable selectors - Fixes feature info chart - Fixes feature info table
Not sure why it was done before but this change should be harmless.
KeyboardSounds
suggested changes
Jan 4, 2022
| @@ -515,7 +515,7 @@ function calculateDomain(chartItems) { | |||
| const ymax = Math.max(...chartItems.map(c => c.domain.y[1])); | |||
| return { | |||
| x: [xmin, xmax], | |||
| y: [Math.min(0, ymin), ymax] | |||
| y: [ymin, ymax] | |||
There was a problem hiding this comment.
I have a suspicion that this is going to break some dataset, somewhere, that was depending on us clamping the min of the y domain to zero. But this is probably one of those situations where we tell people to fix their own data.
There was a problem hiding this comment.
Yeah, i think so too, but this shouldn't be the default behavior. If we find that we need it somewhere we can add a flag to force it per item. The problem with clamping automatically is that the when displaying a single chart that has y value >>> 0 the chart line looks flat loosing all the bumps and details which is bad.
KeyboardSounds
approved these changes
Jan 5, 2022
|
Thanks for the merge @KeyboardSounds! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
titleinstead ofnameas property names.Previously:
Test link:
http://ci.terria.io/fix-sos/#clean&https://raw.githubusercontent.com/TerriaJS/saas-catalogs-public/main/neii/water/prod.json
Checklist
doc/.