Add support for WMS 1.1.1 + other WMS improvements

[nf-s]

Fixes TerriaJS/neii-viewer#218 #5410 #4777 #2590

• Improve WMS 1.1.1 support
  • Added useWmsVersion130 trait - Use WMS version 1.3.0. True by default (unless url has "version=1.1.1" or "version=1.1.0"), if false, then WMS version 1.1.1 will be used.
  • Added getFeatureInfoFormat trait - Format parameter to pass to GetFeatureInfo requests (as info_format query parameter). Defaults to "application/json", "application/vnd.ogc.gml", "text/html" or "text/plain" - depending on GetCapabilities response
• Add legendBackgroundColor to LegendOwnerTraits and backgroundColor to LegendTraits
• Add sld_version=1.1.0 to GetLegendGraphics requests
• Filter "styles","version","format","srs","crs" conflicting query parameters from WMS url
• WMS styles, tileWidth, tileHeight and crs/srs will use value in url if it is defined (similar to existing behavior with layers and version)
• WMS will now show warning if invalid layers (eg if the specified layers don't exist in GetCapabilities)

Notes about WMS query changes

WMS Exceptions

application/vnd.ogc.se_xml is the default value for WMS 1.1.1
XML is the new default for WMS 1.3.0

From WMS 1.1.1 spec

From WMS 1.3.0 spec

Add sld_version to GetLegendGraphics requests

As it is mandatory

From WMS-SLD 1.1.0 spec

Test: WMS 1.1.1 and Legend backgroundColor

Catalog

{
  "workbench": [],
  "catalog": [
    {
      "type": "wms",
      "name": "Legend with background test (and WMS 1.1.1)",
      "url": "http://www.bom.gov.au/cgi-bin/ws/gis/ncc/cdio/wxs?service=WMS&version=1.1.1&request=GetCapabilities",
      "layers": "IDCJCM001900"
    }
  ]
}

After vs Before

• http://ci.terria.io/wms-default-params/#clean&https://gist.githubusercontent.com/nf-s/76ae92576b11dfb28b537a9a4a9b09cf/raw/59a57762ed5a4306ac9211d047f2638a184b62f9/wms-1-1-1.json&share=s-jj27aoTkG9rRdybRYV6cj82vOoG
• http://ci.terria.io/main/#clean&https://gist.githubusercontent.com/nf-s/76ae92576b11dfb28b537a9a4a9b09cf/raw/59a57762ed5a4306ac9211d047f2638a184b62f9/wms-1-1-1.json&share=s-jj27aoTkG9rRdybRYV6cj82vOoG

You can ignore error in main CI link

Note in main

• Feature picking doesn't work
• No Legend present

Test: random WMS working before and after

Some random other WMS layers in NationalMap - should be unchanged for both branches

• http://ci.terria.io/wms-default-params/#configUrl=https://nationalmap.gov.au/config.json&share=s-3tiHRK2ujwOFlcCKEoUEUcqrmyP&playStory=1
• http://ci.terria.io/main/#configUrl=https://nationalmap.gov.au/config.json&share=s-3tiHRK2ujwOFlcCKEoUEUcqrmyP&playStory=1

Test: WMS with invalid layers

After vs Before

• http://ci.terria.io/wms-default-params/#configUrl=https://nationalmap.gov.au/config.json&share=s-fzfO6oxzThz2hJ2uPBBWGVz5EZR
• Must click "Add to Map" to see error http://ci.terria.io/main/#configUrl=https://nationalmap.gov.au/config.json&share=s-fzfO6oxzThz2hJ2uPBBWGVz5EZR

Checklist

• There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
• I've updated relevant documentation in doc/.
• I've updated CHANGES.md with what I changed.
• I've provided instructions in the PR description on how to test this PR.

[na9da]

Doubt: So we fail the dataset even if we have valid layers? Is that the intention?

[nf-s]

I think for the moment this is fine - as it is what would happen previous to the PR.

But in the future it might be worth showing a warning message for invalid layers, and then just showing valid layers anyway

[na9da]

Great work @nf-s.

Just one comment.