Bug: Multiple items with same name from different providers

[mithunbharadwaj]

No description provided.

[ateska]

Keep pitem = uniq.get(item.name) and test for a None ... it does the same with the half of the cost.

[eliska-n]

This is probably fine. I didn't look into the code much but I tested it on a library example. However, I found that subscribing to the library in the filesystem provider is broken and it is because of this MR: #407

Let's sum up asab.library functionality and discuss testing suits - manual or unit tests. It is becoming more and more important.

13-Jul-2023 14:00:35.948043 ERROR root Task exception was never retrieved
{'future': <Task finished name='Task-7' coro=<MyApplication.on_library_ready() done, defined at /home/eliska/teskalabs/playground/asab_library/asab-library-git-example.py:38> exception=TypeError("FileSystemLibraryProvider._list() missing 1 required positional argument: 'index'")>}
Traceback (most recent call last):
  File "/home/eliska/teskalabs/playground/asab_library/asab-library-git-example.py", line 46, in on_library_ready
    await self.LibraryService.subscribe("/")
  File "/home/eliska/teskalabs/asab/asab/library/service.py", line 383, in subscribe
    await provider.subscribe(path)
  File "/home/eliska/teskalabs/asab/asab/library/providers/filesystem.py", line 176, in subscribe
    self._subscribe_recursive(path, path)
  File "/home/eliska/teskalabs/asab/asab/library/providers/filesystem.py", line 188, in _subscribe_recursive
    items = self._list(path_to_be_listed)
TypeError: FileSystemLibraryProvider._list() missing 1 required positional argument: 'index'

[eliska-n]

remove print

[eliska-n]

It is ok, I can see just one file from one layer.
Subscribe is also working for the filesystem provider. Maybe it works too much. When I subscribe to the library, I subscribe to all providers. Some files are overridden and, thus, "not visible" to the consumer of the library items. However, the subscribe functionality does not care about the layers and signals any changes even for the files that are "not visible". What is the desired functionality here @ateska ? (I think this is fine and the processes linked to changes to the library should be graceful to this, but maybe I'm wrong.)

[ateska]

It is ok, I can see just one file from one layer.
Subscribe is also working for the filesystem provider. Maybe it works too much. When I subscribe to the library, I subscribe to all providers. Some files are overridden and, thus, "not visible" to the consumer of the library items. However, the subscribe functionality does not care about the layers and signals any changes even for the files that are "not visible". What is the desired functionality here @ateska ? (I think this is fine and the processes linked to changes to the library should be graceful to this, but maybe I'm wrong.)

It is OK for now. It could be refined in the future.