Issue: Search Box does not appear after selecting it in the filter of the admin list.

[kaladay]

This is the first solution described below that fully hides the "Search Box" from the filter list to avoid this confusion. The previous solution of hiding the "Search Box" is incomplete and still displays the "Search Box" in the "Disabled Filters" column. The "Search Box" is filtered out of the "Disabled Filters" by this commit.

The following are the results of the investigation into this problem: The Search Box filter, when selected, gets saved to the database and returned to the UI on an appropriate /submission-list/filter-columns-by-user call.

What is happening is that the Search Box is explicitly being removed from the filter list:

• Vireo/src/main/webapp/app/controllers/submission/submissionListController.js

  Line 150 in 61fb587

  return slc.title !== 'Search Box';

And then later is handled differently as an "Excluded Column":

• Vireo/src/main/webapp/app/controllers/submission/submissionListController.js

  Line 172 in db2b4ca

  $scope.excludedColumns.push(SubmissionListColumnRepo.findByTitle('Search Box'));

It appears to be originally added here with the exluded column:

• c39ff04
• Search box all column search filter #285

Vireo Slack messages relating to Search Box:

• https://texas-digital-library.slack.com/archives/C7R78CADB/p1550676084006100
• https://texas-digital-library.slack.com/archives/C7R78CADB/p1682428409804819?thread_ts=1682428314.318099&cid=C7R78CADB
• https://texas-digital-library.slack.com/archives/C7R78CADB/p1550696674010100

Referenced Github issues from the conversations:

• Search Box failing to select any items in list view #1146

[kaladay]

Closing with the proof of concept being manually inserted into the issue: #1875 .