-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose diagnose.report as a function #1917
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1917 +/- ##
==========================================
- Coverage 99.82% 99.80% -0.03%
==========================================
Files 71 71
Lines 6943 7035 +92
==========================================
+ Hits 6931 7021 +90
- Misses 12 14 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Can I see an example of the report? |
@willmcgugan Added the output to the original post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it may be worth adding some additional env vars. Not quite everything, since users might have issues re privacy.
In addition to the Jupyter ones, I would add:
TERM
COLORTERM
CLICOLOR
NO_COLOR
TERM_PROGRAM
COLUMNS
LINES
Maybe extract those to a dict and pretty print them with
Panel(Pretty(env_vars))
Will do |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
11.2.0 Added Add support for US spelling of "gray" in ANSI color names Textualize/rich#1890 Added rich.diagnose.report to expose environment debugging logic as function Textualize/rich#1917 Added classmethod Progress.get_default_columns() to get the default list of progress bar columns Textualize/rich#1894 Fixed Fixed performance issue in measuring text Fixed test failures on PyPy3 Textualize/rich#1904
Type of changes
Checklist
Description
Adds
diagnose.report
function. Also adds some additional information from env vars if the user is using Jupyter, that might help convey what platform they're using if they don't specify in the bug report.I've added the file as an omission to coverage reporting since it's only used for debug purposes.