Skip to content

Latest commit

 

History

History
95 lines (61 loc) · 4.75 KB

CONTRIBUTING.md

File metadata and controls

95 lines (61 loc) · 4.75 KB
Raw

Contributing to notary

Before reporting an issue...

If your problem is with...

Then please do not report your issue here - you should instead report it to https://support.docker.com

If you...

  • need help setting up notary
  • can't figure out something
  • are not sure what's going on or what your problem is

Then please do not open an issue here yet - you should first try one of the following support forums:

  • irc: #docker-trust on freenode

Reporting an issue properly

By following these simple rules you will get better and faster feedback on your issue.

  • search the bugtracker for an already reported issue

If you found an issue that describes your problem:

  • please read other user comments first, and confirm this is the same issue: a given error condition might be indicative of different problems - you may also find a workaround in the comments
  • please refrain from adding "same thing here" or "+1" comments
  • you don't need to comment on an issue to get notified of updates: just hit the "subscribe" button
  • comment if you have some new, technical and relevant information to add to the case

If you have not found an existing issue that describes your problem:

  1. create a new issue, with a succinct title that describes your issue:
  • bad title: "It doesn't work with my docker"
  • good title: "Publish fail: 400 error with E_INVALID_DIGEST"
  1. copy the output of:
  • notary version or docker version
  1. Run notary or docker with the -D option for debug output, and please include a copy of the command and the output.
  2. If relevant, copy your notaryserver and notarysigner logs that show the error (this is likely the output from running docker-compose up)

Contributing a patch for a known bug, or a small correction

You should follow the basic GitHub workflow:

  1. fork
  2. commit a change
  3. make sure the tests pass
  4. PR

Additionally, you must sign your commits. It's very simple:

  • configure your name with git: git config user.name "Real Name" && git config user.email mail@example.com
  • sign your commits using -s: git commit -s -m "My commit"

Some simple rules to ensure quick merge:

  • clearly point to the issue(s) you want to fix in your PR comment (e.g., closes #12345)
  • prefer multiple (smaller) PRs addressing individual issues over a big one trying to address multiple issues at once
  • if you need to amend your PR following comments, please squash instead of adding more commits
  • if fixing a bug or adding a feature, please add or update the relevant CHANGELOG.md entry with your pull request number and a description of the change

Contributing new features

You are heavily encouraged to first discuss what you want to do. You can do so on the irc channel, or by opening an issue that clearly describes the use case you want to fulfill, or the problem you are trying to solve.

If this is a major new feature, you should then submit a proposal that describes your technical solution and reasoning. If you did discuss it first, this will likely be greenlighted very fast. It's advisable to address all feedback on this proposal before starting actual work

Then you should submit your implementation, clearly linking to the issue (and possible proposal).

Your PR will be reviewed by the community, then ultimately by the project maintainers, before being merged.

It's mandatory to:

  • interact respectfully with other community members and maintainers - more generally, you are expected to abide by the Docker community rules
  • address maintainers' comments and modify your submission accordingly
  • write tests for any new code

Complying to these simple rules will greatly accelerate the review process, and will ensure you have a pleasant experience in contributing code to the Registry.

Review and Development notes

  • All merges require LGTMs from any 2 maintainers.
  • We use the git flow model (as best we can) using the releases branch as the stable branch, and the master branch as the development branch. When we get near a potential release, a release branch (release/<semver>) will be created from master. Any PRs that should go into the release should be made against that branch. Hotfixes for a minor release will be added to the branch hotfix/<semver>.

Vendoring new dependency versions

We use VNDR; please update vendor.conf with the new dependency or the new version, and run vndr <top level package name>.