Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate DOIs from Crossref Metadata #186

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

jdddog
Copy link
Contributor

@jdddog jdddog commented Sep 20, 2023

  • Remove duplicate DOIs from Crossref Metadata when used in DOI workflow.
  • Move pre-processing of Crossref Metadata to create_crossref_metadata SQL script.
  • create_doi SQL script:
    • Remove UPPER(TRIM(doi)) statements from create_doi and move to individual table pre-processing.
    • Use more specific table references.
  • Remove create_book as it is unused.

@jdddog jdddog marked this pull request as draft September 20, 2023 20:24
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (064def5) 95.21% compared to head (cec0fee) 95.20%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #186      +/-   ##
===========================================
- Coverage    95.21%   95.20%   -0.02%     
===========================================
  Files           20       20              
  Lines         5206     5209       +3     
  Branches       719      720       +1     
===========================================
+ Hits          4957     4959       +2     
  Misses         161      161              
- Partials        88       89       +1     
Files Changed Coverage Δ
academic_observatory_workflows/model.py 97.80% <100.00%> (+<0.01%) ⬆️
...ic_observatory_workflows/workflows/doi_workflow.py 93.75% <100.00%> (-0.35%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdddog jdddog marked this pull request as ready for review September 21, 2023 04:44
Copy link
Collaborator

@alexmassen-hane alexmassen-hane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jamie. All of the UPPER(TRIM(doi)) statements in the create_doi script always annoyed me. Looks good.

@jdddog
Copy link
Contributor Author

jdddog commented Sep 22, 2023

Thanks Jamie. All of the UPPER(TRIM(doi)) statements in the create_doi script always annoyed me. Looks good.

Thanks. Haha they were annoying me too!

@jdddog jdddog added this pull request to the merge queue Sep 22, 2023
Merged via the queue into develop with commit ffa9d4d Sep 22, 2023
@jdddog jdddog deleted the fix/doi-wf-cf-metadata-duplicate-dois branch October 20, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants