Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform deploy may 2023 fixes #620

Merged
merged 10 commits into from
Jun 13, 2023
Merged

Conversation

jdddog
Copy link
Contributor

@jdddog jdddog commented May 29, 2023

  • Increase BigQuery single query limit
  • Terraform: remove database protector, set deletion_protection_enabled = true to stops the database being deleted at the GCP platform level, and set external IPs as sensitive.
  • For ElasticImportWorkflow use data interval end for snapshot date.

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage: 69.23% and project coverage change: -0.08 ⚠️

Comparison is base (19eb82b) 87.79% compared to head (a6042a3) 87.72%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #620      +/-   ##
===========================================
- Coverage    87.79%   87.72%   -0.08%     
===========================================
  Files           38       38              
  Lines         5130     5140      +10     
  Branches       620      622       +2     
===========================================
+ Hits          4504     4509       +5     
- Misses         495      496       +1     
- Partials       131      135       +4     
Impacted Files Coverage Δ
...tory/platform/workflows/elastic_import_workflow.py 77.36% <66.66%> (-0.61%) ⬇️
...ervatory-platform/observatory/platform/bigquery.py 89.23% <100.00%> (-0.85%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jdddog jdddog force-pushed the fix/terraform-deploy-may-2023 branch from d5c0b1b to a850fcf Compare June 6, 2023 03:40
@jdddog jdddog marked this pull request as ready for review June 13, 2023 05:13
@jdddog jdddog merged commit 431da66 into develop Jun 13, 2023
@jdddog jdddog deleted the fix/terraform-deploy-may-2023 branch June 13, 2023 05:13
jdddog added a commit that referenced this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant