-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terraform deploy may 2023 fixes #620
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jdddog
commented
May 29, 2023
•
edited
Loading
edited
- Increase BigQuery single query limit
- Terraform: remove database protector, set deletion_protection_enabled = true to stops the database being deleted at the GCP platform level, and set external IPs as sensitive.
- For ElasticImportWorkflow use data interval end for snapshot date.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #620 +/- ##
===========================================
- Coverage 87.79% 87.72% -0.08%
===========================================
Files 38 38
Lines 5130 5140 +10
Branches 620 622 +2
===========================================
+ Hits 4504 4509 +5
- Misses 495 496 +1
- Partials 131 135 +4
☔ View full report in Codecov by Sentry. |
…ork_name and add sensitive = true params to external IP outputs
d5c0b1b
to
a850fcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.