Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Add FTP Server #621

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Feature/Add FTP Server #621

merged 3 commits into from
Jun 26, 2023

Conversation

alexmassen-hane
Copy link
Contributor

Need to add a FTP server feature to locally host a directory for anonymous access for use by future workflows and tests.
Unable to use the existing SFTP functions as they are different protocols.

@alexmassen-hane alexmassen-hane force-pushed the feature/add-ftp-server branch from 6e7a0c9 to ed74bb4 Compare June 21, 2023 05:51
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 96.77% and project coverage change: -0.01 ⚠️

Comparison is base (658705f) 87.73% compared to head (ed74bb4) 87.73%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #621      +/-   ##
===========================================
- Coverage    87.73%   87.73%   -0.01%     
===========================================
  Files           38       38              
  Lines         5138     5169      +31     
  Branches       622      623       +1     
===========================================
+ Hits          4508     4535      +27     
- Misses         498      501       +3     
- Partials       132      133       +1     
Impacted Files Coverage Δ
...rm/observatory/platform/observatory_environment.py 87.45% <96.77%> (+0.54%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jdddog jdddog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Alex, thanks for the PR, it looks good.

@jdddog jdddog merged commit 1e16b5c into develop Jun 26, 2023
@jdddog jdddog deleted the feature/add-ftp-server branch June 26, 2023 02:05
jdddog pushed a commit that referenced this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants