Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated naming convention #658

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

keegansmith21
Copy link
Contributor

@keegansmith21 keegansmith21 commented May 29, 2024

Implemented the following changes:

  • Renamed DatasetAPI parameters with bq_ prefixes where relevant
  • Renamed dataset_id in DatasetRelease class to entity_id and updated schema accordingly

Note that this will require table reuploads for the current oaebu workflow projects due to the schema changes once merged.

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.64%. Comparing base (9188399) to head (0fd5eb7).
Report is 7 commits behind head on feature/astro-refactor.

Files with missing lines Patch % Lines
observatory_platform/dataset_api.py 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           feature/astro-refactor     #658   +/-   ##
=======================================================
  Coverage                   79.64%   79.64%           
=======================================================
  Files                          22       22           
  Lines                        2564     2564           
  Branches                      351      351           
=======================================================
  Hits                         2042     2042           
  Misses                        426      426           
  Partials                       96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keegansmith21 keegansmith21 marked this pull request as ready for review May 30, 2024 00:04
@keegansmith21 keegansmith21 requested a review from jdddog May 30, 2024 00:05
Copy link
Contributor

@jdddog jdddog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Keegan, these changes look good to me.

@jdddog jdddog merged commit 7b06f0f into feature/astro-refactor May 31, 2024
4 checks passed
@jdddog jdddog deleted the dataset_api_naming branch May 31, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants