Ant: new implementation using boost polygon #5098
Conversation
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
…and repair_antenna Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
| struct PinType; | ||
| struct GraphNode; | ||
|
|
||
| struct InfoType |
There was a problem hiding this comment.
InfoType is too generic. What would you like to express here? The violation itself, the data computed for each gate?
| } | ||
| }; | ||
|
|
||
| typedef std::unordered_map<dbTechLayer*, InfoType> LayerInfoVector; |
There was a problem hiding this comment.
Similar question here. What is LayerInfo? Info is a bad name because it says nothing about what it represents in the code.
|
|
||
| ///////////////////////////////////////////////////////////////////////////////// | ||
| std::unordered_map<odb::dbTechLayer*, GraphNodeVector> node_by_layer_map_; | ||
| std::unordered_map<std::string, LayerInfoVector> info_; |
There was a problem hiding this comment.
Change info_ for a more meaningful name.
| @@ -94,6 +153,9 @@ class AntennaChecker | |||
|
|
|||
| void findMaxWireLength(); | |||
|
|
|||
| vector<Violation> getAntennaViolations2(dbNet* net, | |||
There was a problem hiding this comment.
After finishing the reviews, I believe we will deprecate the old code, so we'll not have two functions with the same name.
@maliberty do you think we should completely remove the old code?
| void calculateAreas(); | ||
| void calculatePAR(); | ||
| void calculateCAR(); | ||
| int checkInfo(dbNet* db_net, |
There was a problem hiding this comment.
Change checkInfo for a more meaningful name (related to the comments about InfoType being a bad struct name).
|
@luis201420 you will need to update the repair_antennas unit tests and the ant unit tests ok files. |
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
I'm going to update it, I'm checking the differences in the unit tests. |
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: luis201420 <tauro_luisito_20@hotmail.com>
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| namespace ant { | ||
|
|
||
| namespace gtl = boost::polygon; | ||
| using namespace gtl::operators; |
There was a problem hiding this comment.
warning: do not use namespace using-directives; use using-declarations instead [google-build-using-namespace]
using namespace gtl::operators;
^Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
|
Secure-ci is running with the latest updates. If everything passes, this PR should be ready to merge. |
|
@vvbandeira This is ready to merge. |
Fixes #3892
I ran a secure-ci with only the public designs, I'm waiting for the results