Skip to content

Update Playfair explanation #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 25, 2022
Merged

Update Playfair explanation #191

merged 5 commits into from
Oct 25, 2022

Conversation

soxfox42
Copy link
Contributor

I fixed up a few things in the documentation of the Playfair cipher:

  • Letter matrices were incorrect, i and k were in the wrong order (Kudos to @BillyOwen for pointing this one out to me)
  • The documentation referred to Z as a filler character, but the implementation (and most explanations of the cipher) uses X
  • I think my reworded explanation of splitting duplicate letter digraphs is slightly clearer than the original.

@soxfox42
Fix Playfair example matrices
5c10c04
@soxfox42
Change Playfair filler letter to X
fde127d 
This matches the Python implementation, the video linked on the page,
and most documentation of the Playfair cipher.
@soxfox42
Clarify duplicate pairs in Playfair
34ecdbc 
I think this wording is a little clearer when it comes to how double
letter digraphs should be handled.
@Panquesito7 Panquesito7 requested a review from appgurueu October 17, 2022 02:15
@vbrazo vbrazo merged commit c8508db into TheAlgorithms:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

@appgurueu appgurueu appgurueu approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@AnupKumarPanwar AnupKumarPanwar Awaiting requested review from AnupKumarPanwar

@ashwek ashwek Awaiting requested review from ashwek

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soxfox42 @vbrazo @appgurueu @Panquesito7