Skip to content

feat: add maximum circular subarray sum #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Feb 6, 2023
Merged

feat: add maximum circular subarray sum #2242

merged 24 commits into from
Feb 6, 2023

Conversation

sumanbmondal
Copy link
Contributor

Description of Change

Added the Maximum Circular Subarray Sum under Dynamic Programming

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
Added the Maximum Circular Subarray Sum problem which uses Kadane's algorithm.

@sumanbmondal
Copy link
Contributor Author

Can someone please review the PR?

Panquesito7
Panquesito7 requested changes Dec 30, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please enable GitHub Actions in your repository of this fork in this link: https://github.com/sumanbmondal/C-Plus-Plus/actions

@Panquesito7 Panquesito7 added enhancement New feature or request automated tests are failing Do not merge until tests pass Proper Documentation Required requested to write the documentation properly labels Dec 30, 2022
Panquesito7
Panquesito7 requested changes Jan 2, 2023
View reviewed changes
@Panquesito7 Panquesito7 added requested changes changes have been requested and removed automated tests are failing Do not merge until tests pass Proper Documentation Required requested to write the documentation properly labels Jan 2, 2023
sumanbmondal and others added 7 commits January 2, 2023 08:30
@sumanbmondal @Panquesito7
Update dynamic_programming/maximum_circular_subarray.cpp
f00e9b2 
Co-authored-by: David Leal <halfpacho@gmail.com>
@sumanbmondal
Update maximum_circular_subarray.cpp
b3a9ac4
@sumanbmondal @Panquesito7
Update dynamic_programming/maximum_circular_subarray.cpp
658fed4 
Co-authored-by: David Leal <halfpacho@gmail.com>
@sumanbmondal @Panquesito7
Update dynamic_programming/maximum_circular_subarray.cpp
441d678 
Co-authored-by: David Leal <halfpacho@gmail.com>
@sumanbmondal @Panquesito7
Update dynamic_programming/maximum_circular_subarray.cpp
696aa96 
Co-authored-by: David Leal <halfpacho@gmail.com>
@sumanbmondal @Panquesito7
Update dynamic_programming/maximum_circular_subarray.cpp
78643d8 
Co-authored-by: David Leal <halfpacho@gmail.com>
@sumanbmondal @Panquesito7
Update dynamic_programming/maximum_circular_subarray.cpp
b26f54d 
Co-authored-by: David Leal <halfpacho@gmail.com>
@sumanbmondal
Copy link
Contributor Author

@Panquesito7 I've made the changes you required. Can you please review it now?

Panquesito7
Panquesito7 reviewed Jan 17, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 😄

krishnacx
krishnacx reviewed Jan 18, 2023
View reviewed changes
Copy link

@krishnacx krishnacx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

sumanbmondal and others added 2 commits January 18, 2023 16:17
@sumanbmondal @Panquesito7
Update dynamic_programming/maximum_circular_subarray.cpp
ddf6da4 
Co-authored-by: David Leal <halfpacho@gmail.com>
@sumanbmondal
Update maximum_circular_subarray.cpp
3b8debe 
Fixed the comments according to @krishnacx
@sumanbmondal sumanbmondal requested review from krishnacx and Panquesito7 and removed request for krishnacx and Panquesito7 January 18, 2023 10:53
krishnacx
krishnacx previously approved these changes Jan 19, 2023
View reviewed changes
Panquesito7
Panquesito7 reviewed Jan 26, 2023
View reviewed changes
Panquesito7
Panquesito7 approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Thank you! 🚀

@sumanbmondal
Copy link
Contributor Author

Awesome work. Thank you! 🚀

Thank YOU for helping me out so much. I would be so happy if this algorithm came in my question paper 😋.

@sumanbmondal
Copy link
Contributor Author

@tjgurwara99 can you approve the running workflows and merge this as well? Thanks a lot.

krishnacx
krishnacx reviewed Feb 3, 2023
View reviewed changes
@Panquesito7
Copy link
Member

Will be merging for now. If there are any objections/changes needed, feel free to create another PR. 🙂

@Panquesito7 Panquesito7 merged commit 0f20cdc into TheAlgorithms:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjgurwara99 tjgurwara99 tjgurwara99 approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

+1 more reviewer

@krishnacx krishnacx krishnacx left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement New feature or request requested changes changes have been requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sumanbmondal @Panquesito7 @tjgurwara99 @krishnacx