Fix: use uint64_t for input and counter in countSetBits #3003
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Updated the
countSetBits
function in bit_manipulation/count_of_set_bits.cpp to improve type safety and correctness:int64_t
touint64_t
to ensure only non-negative numbers are allowed.count
fromint
touint64_t
to match the return type and prevent any theoretical overflow.This ensures the function is consistent, safe, and fully aligned with the intended use of counting set bits in non-negative integers.
Checklist
Notes:
Improves type safety for
countSetBits
function without changing its behavior for normal inputs.