-
Notifications
You must be signed in to change notification settings - Fork 1.6k
LU-decomposition algorithm implementation #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 86.70% 87.21% +0.50%
==========================================
Files 55 57 +2
Lines 2166 2252 +86
==========================================
+ Hits 1878 1964 +86
Misses 288 288
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good! I have added some minor comments though. Could you also specify which algorithm you use for LU decomposition as I wanted to learn it, but couldn't find. And please add to unit tests a check that product of produced matrices is, in fact, source matrix.
@siriak, minor issues are fixed now! If you want to get familiar with this algorithm you can read about it in the book "Algorithms and Datastructures" by A. Levitin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Please include a summary of the change. Please also include relevant motivation and context (if applicable).