Skip to content

LU-decomposition algorithm implementation #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 19, 2020
Merged

LU-decomposition algorithm implementation #138

merged 11 commits into from
Apr 19, 2020

Conversation

kaydotdev
Copy link
Contributor

Please include a summary of the change. Please also include relevant motivation and context (if applicable).

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added comments to hard-to-understand areas of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the comments
  • I have made corresponding changes to the README.md

@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #138 into master will increase coverage by 0.50%.
The diff coverage is 95.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   86.70%   87.21%   +0.50%     
==========================================
  Files          55       57       +2     
  Lines        2166     2252      +86     
==========================================
+ Hits         1878     1964      +86     
  Misses        288      288              
Impacted Files Coverage Δ
Utilities/Extensions/MatrixExtensions.cs 81.81% <81.81%> (ø)
Algorithms/Numeric/Decomposition/LU.cs 100.00% <100.00%> (ø)
Algorithms/Search/FastSearcher.cs 91.30% <0.00%> (+8.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e07c05...04bc302. Read the comment docs.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! I have added some minor comments though. Could you also specify which algorithm you use for LU decomposition as I wanted to learn it, but couldn't find. And please add to unit tests a check that product of produced matrices is, in fact, source matrix.

@kaydotdev
Copy link
Contributor Author

@siriak, minor issues are fixed now! If you want to get familiar with this algorithm you can read about it in the book "Algorithms and Datastructures" by A. Levitin.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@siriak siriak merged commit 7c12b8f into TheAlgorithms:master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants