Skip to content

Cleanup minor things #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 8, 2021
Merged

Cleanup minor things #221

merged 17 commits into from
May 8, 2021

Conversation

siriak
Copy link
Member

@siriak siriak commented May 1, 2021

Update coding standards in .editorconfig to be in line with stylecop.
Apply code style.
Add missing links to README.

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md
  • I have made corresponding changes to the DIRECTORY.md

@siriak siriak marked this pull request as draft May 1, 2021 11:32
@siriak siriak marked this pull request as ready for review May 2, 2021 19:49
@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #221 (fb2dc40) into master (6f4407e) will decrease coverage by 0.10%.
The diff coverage is 94.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
- Coverage   93.31%   93.21%   -0.11%     
==========================================
  Files         108      108              
  Lines        4909     4850      -59     
==========================================
- Hits         4581     4521      -60     
- Misses        328      329       +1     
Impacted Files Coverage Δ
Algorithms/DataCompression/HuffmanCompressor.cs 98.91% <ø> (ø)
Algorithms/DataCompression/Translator.cs 100.00% <ø> (ø)
Algorithms/Encoders/SoundexEncoder.cs 100.00% <ø> (ø)
...ithms/Knapsack/DynamicProgrammingKnapsackSolver.cs 100.00% <ø> (ø)
Algorithms/Knapsack/NaiveKnapsackSolver.cs 100.00% <ø> (ø)
Algorithms/Numeric/AliquotSumCalculator.cs 100.00% <ø> (ø)
Algorithms/Numeric/BinomialCoefficient.cs 100.00% <ø> (ø)
Algorithms/Numeric/Factorial.cs 100.00% <ø> (ø)
...s/Numeric/Factorization/TrialDivisionFactorizer.cs 100.00% <ø> (ø)
Algorithms/Numeric/GaussJordanElimination.cs 97.46% <ø> (ø)
... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f4407e...fb2dc40. Read the comment docs.

@siriak siriak merged commit 1e861b0 into master May 8, 2021
@siriak siriak deleted the cleanup branch May 8, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant