Skip to content

Add implementation for Josephus Problem solver #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 18, 2022

Conversation

Kalkwst
Copy link
Contributor

@Kalkwst Kalkwst commented Oct 15, 2022

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md

@Kalkwst Kalkwst requested a review from siriak as a code owner October 15, 2022 06:54
@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Base: 95.66% // Head: 95.67% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7c9f1db) compared to base (8d0729b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #356   +/-   ##
=======================================
  Coverage   95.66%   95.67%           
=======================================
  Files         209      210    +1     
  Lines        8699     8713   +14     
=======================================
+ Hits         8322     8336   +14     
  Misses        377      377           
Impacted Files Coverage Δ
Algorithms/Numeric/JosephusProblem.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the PR check so that I could merge. It seems that tests are failing

@Kalkwst
Copy link
Contributor Author

Kalkwst commented Oct 18, 2022

Please fix the PR check so that I could merge. It seems that tests are failing

Fixed

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit bb5c243 into TheAlgorithms:master Oct 18, 2022
damiansikora85 pushed a commit to damiansikora85/C-Sharp that referenced this pull request Oct 18, 2022
@Kalkwst Kalkwst deleted the feature/Numeric/JosephusProblem branch October 4, 2023 13:27
@Kalkwst Kalkwst restored the feature/Numeric/JosephusProblem branch October 4, 2023 13:27
@Kalkwst Kalkwst deleted the feature/Numeric/JosephusProblem branch October 4, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants