Skip to content

Conversation

siriak
Copy link
Member

@siriak siriak commented Jan 10, 2024

I'm removing those attributes because they are redundant. NUnit can already figure out that those are tests based on TestCase attribute.

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6922799) 94.50% compared to head (57e9dee) 94.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #438   +/-   ##
=======================================
  Coverage   94.50%   94.50%           
=======================================
  Files         234      234           
  Lines        9843     9843           
  Branches     1455     1455           
=======================================
  Hits         9302     9302           
  Misses        381      381           
  Partials      160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siriak siriak merged commit 9b9c5b6 into master Jan 10, 2024
@siriak siriak deleted the remove-redundant-attributes branch January 10, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant