Skip to content

refresh on shannon-fano algorithm and added tests #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 29, 2019

Conversation

1fisedi
Copy link
Contributor

@1fisedi 1fisedi commented Jun 23, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 23, 2019

Codecov Report

Merging #68 into master will increase coverage by 6.58%.
The diff coverage is 97.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   31.49%   38.07%   +6.58%     
==========================================
  Files          33       34       +1     
  Lines        1594     1770     +176     
  Branches      247      272      +25     
==========================================
+ Hits          502      674     +172     
- Misses       1085     1088       +3     
- Partials        7        8       +1
Impacted Files Coverage Δ
Algorithms/DataCompression/ShannonFano.cs 97.72% <97.72%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd21eac...320c830. Read the comment docs.

@TheAlgorithms TheAlgorithms deleted a comment Jun 24, 2019
@TheAlgorithms TheAlgorithms deleted a comment Jun 24, 2019
@TheAlgorithms TheAlgorithms deleted a comment Jun 24, 2019
@TheAlgorithms TheAlgorithms deleted a comment Jun 24, 2019
@TheAlgorithms TheAlgorithms deleted a comment Jun 24, 2019
@TheAlgorithms TheAlgorithms deleted a comment Jun 24, 2019
@TheAlgorithms TheAlgorithms deleted a comment Jun 24, 2019
@TheAlgorithms TheAlgorithms deleted a comment Jun 24, 2019
@TheAlgorithms TheAlgorithms deleted a comment Jun 24, 2019
@TheAlgorithms TheAlgorithms deleted a comment Jun 24, 2019
@TheAlgorithms TheAlgorithms deleted a comment Jun 26, 2019
@TheAlgorithms TheAlgorithms deleted a comment Jun 26, 2019
@TheAlgorithms TheAlgorithms deleted a comment Jun 26, 2019
@TheAlgorithms TheAlgorithms deleted a comment Jun 26, 2019
@TheAlgorithms TheAlgorithms deleted a comment Jun 26, 2019
@TheAlgorithms TheAlgorithms deleted a comment Jun 26, 2019
@TheAlgorithms TheAlgorithms deleted a comment Jun 26, 2019
@TheAlgorithms TheAlgorithms deleted a comment Jun 26, 2019
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve and merge now and check tests later

@siriak siriak merged commit d34d5c2 into TheAlgorithms:master Jun 29, 2019
Adelhaide22 pushed a commit to Adelhaide22/C-Sharp that referenced this pull request Jul 5, 2019
* Refresh shannon-fano algorithm and add tests
* Reduce shannon-fano complexity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants