Skip to content

Conversation

manimanasamylavarapu
Copy link

fixes #96

Copy link
Contributor

@varunu28 varunu28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove the package
  • Please provide a description for checkIfANumberIsAmstrongOrNot function
  • Provide a description for what actually is an Armstrong number at the top along with an exampel

and implemeted the following review comments.
Remove the package
Please provide a description for checkIfANumberIsAmstrongOrNot function
Provide a description for what actually is an
Armstrong number at the top along with an example

fixes TheAlgorithms#96
@manimanasamylavarapu
Copy link
Author

manimanasamylavarapu commented Oct 21, 2017

@varunu28
Implemented review comments:
new commit in same pull request:
364e27b

Copy link
Contributor

@varunu28 varunu28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the package call and keep the file in Others folder and not the root folder

@manimanasamylavarapu
Copy link
Author

@varunu28 removed package and moved to others

@varunu28
Copy link
Contributor

Thanks for the changes and the PR @manimanasamylavarapu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more algorithms

2 participants