refactor: Enhance docs, code, add tests in SkylineProblem
#6637
+308
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardvan
requested review from
DenizAltunkapan,
yanglbme and
alxkm
as code owners
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6637 +/- ##
============================================
- Coverage 75.74% 75.63% -0.11%
- Complexity 5765 5770 +5
============================================
Files 701 701
Lines 19757 19809 +52
Branches 3831 3848 +17
============================================
+ Hits 14964 14982 +18
- Misses 4214 4231 +17
- Partials 579 596 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DenizAltunkapan
requested changes
Oct 10, 2025
| @@ -1,17 +1,59 @@ | |||
|
|
|||
There was a problem hiding this comment.
Please remove this unnecessary line
| } else if (key instanceof short[] shortArray) { | ||
| keyString = Arrays.toString(shortArray); | ||
| } else { | ||
| keyString = String.valueOf(key); |
There was a problem hiding this comment.
Is this really necessary? Couldn’t this be written in a shorter and more concise way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java