Skip to content

add yt video association algorithm #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

add yt video association algorithm #1007

wants to merge 2 commits into from

Conversation

Exortions
Copy link
Contributor

@Exortions Exortions commented May 8, 2022 •
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

raklaptudirm
raklaptudirm requested changes May 8, 2022
View reviewed changes
Maths/FindMaxRecursion.js
@@ -0,0 +1,38 @@
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these changes from this pull request.

@raklaptudirm raklaptudirm added feature Adds a new feature changes required This pull request needs changes algorithm Adds or improves an algorithm labels May 8, 2022
appgurueu
appgurueu reviewed May 8, 2022
View reviewed changes
Search/test/YoutubeVideoAssociation.test.js
expect(algorithm.isVideoAssociated('dQw4w9WgXcQ', 'Rick Roll')).toBe(false)
})

test('The video should be associated after 11 searches', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't even test for that though?

appgurueu
appgurueu requested changes May 8, 2022
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very wary of this "algorithm". It's pretty much a counter dict applied to YT vids, which seems rather odd to me. Why would this be specific to YT or videos in general?

@Exortions
Copy link
Contributor Author

I'm very wary of this "algorithm". It's pretty much a counter dict applied to YT vids, which seems rather odd to me. Why would this be specific to YT or videos in general?

This algorithm uses YouTube as an example, but it can be applied to many other broader things. It's just association, but applied in a YouTube context. I could re-write it to make it more broad if you'd like.

@Exortions
Copy link
Contributor Author

I'll fix the changes you requested and place them in a new PR.

@Exortions Exortions closed this May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu requested changes

@raklaptudirm raklaptudirm raklaptudirm requested changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Exortions @appgurueu @raklaptudirm