Skip to content

Conversation

Exortions
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@@ -0,0 +1,25 @@
import AssociationAlgorithm from '../YoutubeVideoAssociation'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these changes from here.

@raklaptudirm raklaptudirm added feature Adds a new feature changes required This pull request needs changes algorithm Adds or improves an algorithm labels May 8, 2022
if (left === right) return arr[left]

// left + right shifted is the middle index
const mid = (left + right) >> 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please explain this as x >> y == floor(x / pow(2, y))

@Exortions
Copy link
Contributor Author

Yep, I'll fix this.

@Exortions Exortions closed this May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants