Skip to content

tests: Levenshtein Distance (dynamic programming solution) #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 5, 2022
Merged

tests: Levenshtein Distance (dynamic programming solution) #1114

merged 3 commits into from
Oct 5, 2022

Conversation

JCarlosR
Copy link
Contributor

@JCarlosR JCarlosR commented Oct 1, 2022

Describe your change:

  • Documentation change
  • Add tests for an existing algorithm
  • Add missing comment block on existing algorithm

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.

@appgurueu appgurueu added the tests Adds or fixes tests; issue that points out bugs in the tests label Oct 1, 2022
appgurueu
appgurueu reviewed Oct 1, 2022
View reviewed changes
CarlosZoft
CarlosZoft suggested changes Oct 1, 2022
View reviewed changes
@JCarlosR JCarlosR force-pushed the add-tests-for-dynamic-programming branch from c9c8d1b to 420471a Compare October 4, 2022 06:03
@JCarlosR JCarlosR requested review from CarlosZoft and appgurueu and removed request for CarlosZoft and appgurueu October 4, 2022 06:11
CarlosZoft
CarlosZoft approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@CarlosZoft CarlosZoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@raklaptudirm raklaptudirm changed the title Add tests for Levenshtein Distance (dynamic programming solution) tests: Levenshtein Distance (dynamic programming solution) Oct 5, 2022
@raklaptudirm raklaptudirm merged commit ea7d06a into TheAlgorithms:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

+1 more reviewer

@CarlosZoft CarlosZoft CarlosZoft approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
tests Adds or fixes tests; issue that points out bugs in the tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JCarlosR @appgurueu @CarlosZoft @raklaptudirm