Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct implementation for Date to Day function #1134

Closed
wants to merge 1 commit into from

Conversation

chrisgalvan
Copy link

@chrisgalvan chrisgalvan commented Oct 6, 2022

Fixes #1121
Implement correct modulus operator in javascript
Adjusted the year if month is Jan or Feb, since we are considering March as the starting month (based on the algorith)

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Implement correct modulus operator in javascript
Adjusted the year if month is Jan or Feb, since we are considering March
as the starting month (based on the algorith)
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing modulo looks like a reasonable fix to me. Adapting the formula is preferable however. You can then take it one step further.

@appgurueu
Copy link
Collaborator

Closing in favor of #1125 and #1126, which both get rid of the dirty month dict. using a simple if.

@appgurueu appgurueu closed this Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateToDay.js giving wrong day
2 participants