Skip to content

added two functions to convert between arrays and linked lists #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

KyleMcIndoe
Copy link

theres a note at the start of the file with more details

Open in Gitpod know more

Describe your change:

  • [y ] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [y ] I have read CONTRIBUTING.md.
  • [y ] This pull request is all my own work -- I have not plagiarized.
  • [y ] I know that pull requests will not be merged if they fail the automated tests.
  • [ y] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ y] All new JavaScript files are placed inside an existing directory.
  • [ y] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [ n]All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [n ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

theres a note at the start of the file with more details
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't meet our the style requirements set by our contribution guidelines:

  • Use a proper JSDoc comment. That JS isn't your primary language etc etc. is irrelevant to the code (you may include it in the discussion here on GH however).
  • Yes, listnode should not be a function. You should integrate this with the existing linked list classes by adding a constructor that constructs a linked list from an array (this already exists, so you don't have to do it), and adding a method that turns the linked list into an array (if it doesn't exist).
  • Use let (or const) over var
  • Format your JS properly

@KyleMcIndoe KyleMcIndoe closed this Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants