Skip to content

README.md Spanish #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

README.md Spanish #1310

wants to merge 1 commit into from

Conversation

VMontecinos
Copy link

Spanish translation for the readme

Open in Gitpod know more

Describe your change:

  • [ N ] Add an algorithm?
  • [ N ] Fix a bug or typo in an existing algorithm?
  • [ Y ] Documentation change?

Checklist:

  • [ ✓ ] I have read CONTRIBUTING.md.
  • [ ✓ ] This pull request is all my own work -- I have not plagiarized.
  • [ ✓ ] I know that pull requests will not be merged if they fail the automated tests.
  • [ ✓ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ ✓ ] All new JavaScript files are placed inside an existing directory.
  • [ ✓ ] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [ ✓ ] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • [ ✓ ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Spanish translation for the readme
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't adequately review this, but it looks like an appropriate translation.

@VMontecinos
Copy link
Author

Thanks. I still get the spelling error bc of github thinking it's supposed to be in english. Not sure how to fix that. I did the translation myself, being an argentinian with decent knowledge of basic english, and the spanish translation is coherent and easy to read.

@raklaptudirm
Copy link
Member

raklaptudirm commented Apr 3, 2023

This seems to switch the README.md from English to Spanish, which I don't think is a good change given that everything else is in English. A more appropriate change would be to create a new README-es.md file.

Also, the CI can be overridden by adding the filename to the workflow config.

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Closed due to age label Jun 18, 2023
@VMontecinos VMontecinos closed this by deleting the head repository Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Closed due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants