Skip to content

feat: new algorithm to count bits #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nikolaospanagopoulos
Copy link

@nikolaospanagopoulos nikolaospanagopoulos commented Apr 29, 2023

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a good reason to add this. As I see it, this is pretty much a trivial way to inefficiently count the number of set bits involving much higher level concepts and ultimatively having toString(2) do all the work. It might have its place in code golfing, but algorithmically, I don't see significant educational value. This is "taking a sledgehammer to crack a nut".

It has some JS educational value though.

In its current form, I see the following issues with this PR:

  • No proper doc comment
  • Missing tests; the same tests as for the other implementation should be applied without duplicating (simply copy-pasting) them
  • All the type checks obscure the (trivial) implementation; they should probably be removed
  • Not mentioning the inferiority of this implementation (granted, asymptotically both algos are linear time in the number of bits) as this impl. creates an unnecessary temporary string (e.g. using linear auxiliary space) and throws RegEx at it

Overall, I'd be leaning towards rejecting this. It might be acceptable if the changes are made. @raklaptudirm thoughts?

@nikolaospanagopoulos nikolaospanagopoulos deleted the newBitsCountFunction branch April 29, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants