Skip to content

Update BellmanFord.js #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

JoshiJaimin
Copy link

This code defines the Edge and Graph classes and implements the Bellman-Ford algorithm. You can adjust the vertices and edges to represent your specific graph, and then call the bellmanFord method with the source vertex to find the shortest paths.

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

This code defines the Edge and Graph classes and implements the Bellman-Ford algorithm. You can adjust the vertices and edges to represent your specific graph, and then call the bellmanFord method with the source vertex to find the shortest paths.
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are unfortunately for the worse. The "edge" class is a pure data class; it doesn't need to exist (though its existence may be useful for doc purposes). The Graph class adds a fourth? Graph class.. when we already have 3 Graph classes. There are no JSDoc comments, but side effects (console.log). The example was just stuck in the code, causing side effects when it is imported. The tests were not fixed.

@appgurueu appgurueu closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants