Skip to content

feat: Added string symmetry check algorithm #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Nikunj-bisht
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I don't think this algorithm is a good addition. It's pretty much trivial (esp. if seen as check palindrome + check charset) and solves an oddly specific problem.
(Code-wise it's mostly fine though, but should return a bool rather than strings.)

@raklaptudirm thoughts?

@Nikunj-bisht
Copy link
Contributor Author

ok , no issues i will come up with a new algo

@appgurueu
Copy link
Collaborator

ok , no issues i will come up with a new algo

My advice: Try to stick to generally useful nontrivial standard algorithms. For example Push-Relabel if you want to implement a network flow algorithm. You will ideally learn more (for this, first fully understand the algorithm, then implement it from scratch / memory) and your contributions will be more interesting and useful.

@raklaptudirm
Copy link
Member

Closing PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants