Skip to content

Number of Subset equal to given sum #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2020

Conversation

rverma13927
Copy link
Contributor

@rverma13927 rverma13927 commented May 21, 2020

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@itsvinayak
Copy link
Member

itsvinayak commented May 21, 2020

@rverma13927 please fill check box
and follow npx standard --fix
read CONTRIBUTING.md

use let in place of "var"
change file name according to rules
don't use ';'

@rverma13927
Copy link
Contributor Author

Please tell me it meets your requirement or not.

@itsvinayak
Copy link
Member

@rverma13927 thanks for contributing

@itsvinayak itsvinayak merged commit 735f173 into TheAlgorithms:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants