Skip to content

Conversation

farha1
Copy link
Contributor

@farha1 farha1 commented Oct 3, 2021

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@pomkarnath98 pomkarnath98 merged commit 5ed4227 into TheAlgorithms:master Oct 3, 2021
@farha1
Copy link
Contributor Author

farha1 commented Oct 3, 2021

hi @pomkarnath98 , can you add this pull request as part of hacktoberfest ?

this is my first contribution in Hacktoberfest 2021.. thanks..

@raklaptudirm
Copy link
Member

@pomkarnath98 please wait for my review too before merging.

@raklaptudirm
Copy link
Member

@farha1 Merging a pull request into a hacktoberfest repository automatically marks it as a hacktoberfest contribution.

@farha1
Copy link
Contributor Author

farha1 commented Oct 4, 2021

@farha1 Merging a pull request into a hacktoberfest repository automatically marks it as a hacktoberfest contribution.
O I see..

but why in my hacktoberfest profile still 0 contribution.. do you know? @raklaptudirm

@pomkarnath98
Copy link
Member

@raklaptudirm Did I miss anything in this PR?

@farha1
Copy link
Contributor Author

farha1 commented Oct 4, 2021

apparently I forgot to connect my github account.. only gitlab account.. hmmm..

@raklaptudirm
Copy link
Member

@pomkarnath98 No but you could have.

@pomkarnath98
Copy link
Member

pomkarnath98 commented Oct 4, 2021

@pomkarnath98 No but you could have.

Don't worry @raklaptudirm. I have been reviewing and merging PR for the last 12 months 🙂
PS: And I think, I won't merge any wrong PR in future too 👍

@raklaptudirm
Copy link
Member

Still, its better to have more opinions.

@pomkarnath98
Copy link
Member

okay then, let's follow this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants