Skip to content

Add MinHeap and test #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2021
Merged

Add MinHeap and test #817

merged 3 commits into from
Oct 27, 2021

Conversation

tinatae
Copy link
Contributor

@tinatae tinatae commented Oct 27, 2021 •
edited
Loading

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@tinatae tinatae requested a review from raklaptudirm as a code owner October 27, 2021 01:29
raklaptudirm
raklaptudirm requested changes Oct 27, 2021
View reviewed changes
@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature Reviewed labels Oct 27, 2021
raklaptudirm
raklaptudirm requested changes Oct 27, 2021
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format your code using standard.js.

@raklaptudirm raklaptudirm added the code style issue Failing style checks label Oct 27, 2021
@tinatae
Copy link
Contributor Author

tinatae commented Oct 27, 2021

I put 3 eslint-disable-line in the test file because StandardJS wanted me to remove the 'heap' property in the expected response, but I couldn't get my tests to pass without that there. Hopefully that's okay.

@raklaptudirm raklaptudirm removed changes required This pull request needs changes code style issue Failing style checks labels Oct 27, 2021
@raklaptudirm raklaptudirm merged commit e4808a6 into TheAlgorithms:master Oct 27, 2021
@tinatae
Copy link
Contributor Author

tinatae commented Oct 28, 2021

Hi Rak! Thanks for guiding me through and maintaining. Have a great rest of the week :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tinatae @raklaptudirm